oggy / looksee

Supercharged method introspection in IRB
MIT License
364 stars 14 forks source link

Support Ruby 2.3 #36

Closed mathieujobin closed 8 years ago

mathieujobin commented 8 years ago

my work in progress attempt to support both ruby 2.3 and 2.4 solving issue https://github.com/oggy/looksee/issues/35

I am about to run out of time tonight... so I thought of sharing my progress

mathieujobin commented 8 years ago

i don't know why the casts to st_data_t on the calls to st_foreach dont work in 2.3.x and 2.4.x strangely,... I could remove the cast for other rubies and everything kept passing ?!?

image

mathieujobin commented 8 years ago

my build on my fork

image

the PR build

image

another puzzle

mathieujobin commented 8 years ago

need help here !

josephks commented 8 years ago

Until this fix is in can the gemspec for the current version be modified so bundler doesn't attempt to install looksee on Rubies > 2.2 ?

mathieujobin commented 8 years ago

@josephks https://github.com/oggy/looksee/pull/38

mathieujobin commented 8 years ago

still a work in progress, but I understand a lot more what is going on....