oggy / looksee

Supercharged method introspection in IRB
MIT License
364 stars 14 forks source link

Ruby 2.6.0 support. #49

Closed zw963 closed 5 years ago

zw963 commented 5 years ago

Ruby 2.6.0 is released yesterday.

When i try to install it, got following errors:

Fetching looksee-4.0.0.gem
Building native extensions. This could take a while...
ERROR:  Error installing looksee:
        ERROR: Failed to build gem native extension.

    current directory: /home/zw963/.rvm/gems/ruby-2.6.0@looksee/gems/looksee-4.0.0/ext
/home/zw963/.rvm/rubies/ruby-2.6.0/bin/ruby -I /home/zw963/.rvm/rubies/ruby-2.6.0/lib/ruby/2.6.0 -r ./siteconf20181226-5090-146ozzi.rb extconf.rb
creating Makefile

current directory: /home/zw963/.rvm/gems/ruby-2.6.0@looksee/gems/looksee-4.0.0/ext
make "DESTDIR=" clean

current directory: /home/zw963/.rvm/gems/ruby-2.6.0@looksee/gems/looksee-4.0.0/ext
make "DESTDIR="
compiling mri/mri.c
In file included from mri/2.3.0/internal.h:16:0,
                 from mri/2.3.0/method.h:14,
                 from mri/mri.c:7:
/home/zw963/.rvm/rubies/ruby-2.6.0/include/ruby-2.6.0/ruby/encoding.h:16:2: error: #error "Include this file before internal.h"
 #error "Include this file before internal.h"
  ^~~~~
In file included from mri/2.3.0/internal.h:17:0,
                 from mri/2.3.0/method.h:14,
                 from mri/mri.c:7:
/home/zw963/.rvm/rubies/ruby-2.6.0/include/ruby-2.6.0/ruby/io.h:16:2: error: #error "Include this file before internal.h"
 #error "Include this file before internal.h"
  ^~~~~
In file included from mri/2.3.0/method.h:14:0,
                 from mri/mri.c:7:
mri/2.3.0/internal.h:48:0: warning: "WARN_UNUSED_RESULT" redefined
 #define WARN_UNUSED_RESULT(x) x __attribute__((warn_unused_result))

In file included from /home/zw963/.rvm/rubies/ruby-2.6.0/include/ruby-2.6.0/ruby/ruby.h:24:0,
                 from /home/zw963/.rvm/rubies/ruby-2.6.0/include/ruby-2.6.0/ruby.h:33,
                 from mri/mri.c:1:
/home/zw963/.rvm/rubies/ruby-2.6.0/include/ruby-2.6.0/x86_64-linux/ruby/config.h:149:0: note: this is the location of the previous definition
 #define WARN_UNUSED_RESULT(x) __attribute__ ((__warn_unused_result__)) x

In file included from mri/2.3.0/method.h:14:0,
                 from mri/mri.c:7:
mri/2.3.0/internal.h:70:0: warning: "GCC_VERSION_SINCE" redefined
 #define GCC_VERSION_SINCE(major, minor, patchlevel) \

In file included from /home/zw963/.rvm/rubies/ruby-2.6.0/include/ruby-2.6.0/ruby/ruby.h:29:0,
                 from /home/zw963/.rvm/rubies/ruby-2.6.0/include/ruby-2.6.0/ruby.h:33,
                 from mri/mri.c:1:
/home/zw963/.rvm/rubies/ruby-2.6.0/include/ruby-2.6.0/ruby/defines.h:62:0: note: this is the location of the previous definition
 #  define GCC_VERSION_SINCE(major, minor, patchlevel) \

In file included from mri/2.3.0/method.h:14:0,
                 from mri/mri.c:7:
mri/2.3.0/internal.h:84:30: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
 #if GCC_VERSION_SINCE(4, 6, 0) || __has_extension(c_static_assert)
                              ^
mri/2.3.0/internal.h:84:30: warning: this use of "defined" may not be portable [-Wexpansion-to-defined]
mri/mri.c:15:12: warning: ‘add_method_if_undefined’ defined but not used [-Wunused-function]
 static int add_method_if_undefined(ID method_name, rb_method_entry_t *me, VALUE *names) {
            ^~~~~~~~~~~~~~~~~~~~~~~
cc1: warning: unrecognized command line option ‘-Wno-self-assign’
cc1: warning: unrecognized command line option ‘-Wno-parentheses-equality’
cc1: warning: unrecognized command line option ‘-Wno-constant-logical-operand’
cc1: warning: unrecognized command line option ‘-Wno-cast-function-type’
make: *** [Makefile:244: mri.o] Error 1

make failed, exit code 2

Gem files will remain installed in /home/zw963/.rvm/gems/ruby-2.6.0@looksee/gems/looksee-4.0.0 for inspection.
Results logged to /home/zw963/.rvm/gems/ruby-2.6.0@looksee/extensions/x86_64-linux/2.6.0/looksee-4.0.0/gem_make.out

*** LOCAL GEMS ***
alphabt commented 5 years ago

Would be nice to see this implemented soon. I would love to help out but I lack knowledge on where to start. If anyone can provide some pointers I can try to tackle it with a PR.

Paxa commented 5 years ago

Implemented in https://github.com/oggy/looksee/pull/50

zw963 commented 5 years ago

Wonderful!