oggy / looksee

Supercharged method introspection in IRB
MIT License
364 stars 14 forks source link

Support ruby 2.6 #50

Closed Paxa closed 5 years ago

Paxa commented 5 years ago

Test more rubies

Paxa commented 5 years ago

Tests fail because latest bundler doesn't support ruby 2.2 and ruby 2.1 For 2.3 - 2.6 works well

alphabt commented 5 years ago

From TravisCI:

$ gem update --system
Updating rubygems-update
Fetching: rubygems-update-3.0.2.gem (100%)
ERROR:  Error installing rubygems-update:
    rubygems-update requires Ruby version >= 2.3.0.
ERROR:  While executing gem ... (NoMethodError)
    undefined method `version' for nil:NilClass
The command "gem update --system" failed and exited with 1 during .

rubygems 3 doesn't work on Ruby < 2.3.0. There are two ways that I see to resolve this:

@oggy which one do you prefer? @Paxa thanks for your effort, I hope we can get this merged soon so I can finally upgrade my project to Ruby 2.6

zw963 commented 5 years ago

I think we can use solution 2, just release a new major version of looksee, which drop support Ruby 2.1 & 2.2.

Paxa commented 5 years ago

Agree, It still should support 2.1 and 2.2 just hard to test it in CI

zw963 commented 5 years ago

@Paxa How is it going now? Thanks

Paxa commented 5 years ago

travis can run tests now, but somehow failing for ruby 2.2

You already can use it:

gem 'looksee', github: 'paxa/looksee'
zw963 commented 5 years ago

@Paxa , It worked! Thanks

alphabt commented 5 years ago

@oggy any idea how to resolve the test failure on 2.2?

mathieujobin commented 5 years ago

@Paxa can you put back 2.2.5 and maybe all revision in between up to 2.2.10, to see it might be a problem starting from one of those revision.

mathieujobin commented 5 years ago

Confirmed. It pass up to 2.2.9. Fails only for 2.2.10

https://travis-ci.org/mathieujobin/looksee/builds/501157321

Paxa commented 5 years ago

Thanks, applied

oggy commented 5 years ago

Thanks @Paxa, and everyone else!

To answer the question above, I'm happy to drop support for the older versions. The ruby world is considerably different to when this gem first started out, and following the ruby support cycle these days seems more appropriate.