search

oggy / looksee

Supercharged method introspection in IRB
MIT License
364 stars 14 forks source link

Ruby2.7 #52

Closed mathieujobin closed 4 years ago

mathieujobin commented 4 years ago

You will find this fix quite boring but the breaking line, which was refactored in https://github.com/ruby/ruby/commit/5f35b8ca30cba69968d4d0c885a4bf5c48b03e17 isn't used by looksee and can be simply commented out

looksee installs and works fine in 2.7 with this small change

note the internal.h was split in several files in ruby. but I don't know if we need to care so much... https://github.com/ruby/ruby/commit/5e22f873ed26092522f9bfc617d729bac88b284f

oggy commented 4 years ago

Thanks. As you were pushing this I was looking at it too. I just copied the corresponding headers from ruby 2.7 and it seemed to build ok. I'd prefer not to hack the 2.3 headers to keep support for older rubies more robust.

mathieujobin commented 4 years ago

alright, no worries.

mathieujobin commented 4 years ago

@oggy might be a good idea to update the travis file as well?

suggestion: https://github.com/mathieujobin/looksee/commit/1c7146e2210fc73402522c354413857fd120915e

oggy commented 4 years ago

Great idea, thanks!