search

oggy / tab-switcher

Like a window switcher for your Atom tabs.
MIT License
23 stars 11 forks source link

Switch window is offscreen #49

Closed GillesDebunne closed 8 years ago

GillesDebunne commented 8 years ago

Since the update to Atom 1.8.0, the tab switcher window appears in the top left corner instead of being centered on screen. With long file and path names, it is clipped, making it barely usable.

tab-switcher

This is using Mac OSX 10.11.5, tab-switcher 1.5.1 and Atom 1.8.0. I tried uninstalling / reinstalling the package, but with no success.

Thanks,

G

oggy commented 8 years ago

Funny, I just noticed that myself yesterday. Just pushed a release which should fix this.

Thanks for the report!

GillesDebunne commented 8 years ago

Thanks for this quick fix.

However, the fix seems to have introduced a new problem. When I open the fuzzy-finder:toggle-file-finder (Cmd+T), the search window is now shifted down, partially invisible.

Disabling the tab-switcher package fixes the problem.

G

sirianni commented 8 years ago

In my case, all atom modals are at the bottom of the window. Disabling the position: static rule on atom-panel-container seems to fix it. Strangely, the rule is being applied even though the tab-switcher class is not present on the element.

sirianni commented 8 years ago

Actually, the problem seems to be that the other modal (in my case "fuzzy finder") is nested within a tab-switcher modal:

<atom-panel-container class="modal tab-switcher">
    <atom-panel class="tab-switcher modal overlay from-top" style="display: none; transition-delay: 0.1s;">
        <div class="vertical-axis">
            <ol class="tab-switcher-tab-list" tabindex="-1">
                <li data-id="5"><span class="icon icon-tools"></span><span class="tab-label">Settings</span></li>
            </ol>
        </div>
    </atom-panel>
    <atom-panel class="modal overlay from-top">
        <div class="select-list fuzzy-finder" is="space-pen-div">
        </div>
    </atom-panel>
</atom-panel-container>
oggy commented 8 years ago

@GillesDebunne @sirianni

Dangit, sorry about that. Looks like the panel-container is shared with other panels.

I guess I should stop using panels for this, since themes seem to take liberty with panel positioning, and the tab list is kind of a separate thing. I'm short on time though, so I've just hacked the hack for now.

sirianni commented 8 years ago

Looks like it's fixed - I just upgraded this morning. Thanks for the quick turnaround!