ogham / exa

A modern replacement for ‘ls’.
https://the.exa.website/
MIT License
23.51k stars 660 forks source link

Replace obsolete icons #1178

Closed mtoohey31 closed 1 year ago

mtoohey31 commented 1 year ago

This pull request replaces icons that have been relocated whose old location has been marked as obsolete in nerd-fonts.

The tldr, as I understand it, is that the codepoints used by mdi characters were relocated around the start of 2022 because the original positions conflicted with certain Chinese characters, so they were moved in this nerd-fonts pull request. This pull request updates exa's hard-coded icon values to use the new codepoints. This change should be transparent to users as long as they've updated their font sometime in the last year.

The only difference I noticed was a slight difference between the new and old versions of the xml icon. On kitty, the old icon takes up two cells, messing up the filename's alignment:

2023-04-12T19:14:29,591563750-04:00

The new icon doesn't doesn't seem to do this:

2023-04-12T19:14:20,143546614-04:00

So I think this is an improvement, even though I didn't expect to see any change?

mtoohey31 commented 1 year ago

Looks like the difference I was talking about at the end there is caused by this: https://github.com/ryanoasis/nerd-fonts/issues/1061. Like I mentioned above though, I think this change is in our favour since the smaller icon prevents the columns from becoming misaligned.