search

ogham / exa

A modern replacement for ‘ls’.
https://the.exa.website/
MIT License
23.61k stars 660 forks source link

Prepare CI workflow for Node 12 deprecation #1187

Closed 1stDimension closed 1 year ago

1stDimension commented 1 year ago

The problem

Since 27.09.2022 Node 12 has been deprecated in favour of Node 16. Current CI uses actions based on old version.

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

The goal of this issue is propose to move forward to currently advised Github Actions. The root of the problem is lack of maintenance around actions-rs organisation (no contributions for past 2 years) which is responsible for 2 actions used in CI:

Reddit thread about the org

Propoused solution

Let's switch to dtolnay's version of action. This route was taken here. It's code inside rust's regex crate. If it is good enough for them it will work for us.

1stDimension commented 1 year ago

I close this issue due to lack of response