search

ogham / exa

A modern replacement for ‘ls’.
https://the.exa.website/
MIT License
23.59k stars 660 forks source link

Would you be interested in having a Dockerfile for development? #1225

Closed AgustinRamiroDiaz closed 1 year ago

AgustinRamiroDiaz commented 1 year ago

I could work on a dockerfile/docker-compose to isolate development if it's something you'd like in the repo :)

Maybe it's also useful to create releases to different targets :thinking:

We can even do a dev-container for vscode (https://code.visualstudio.com/docs/devcontainers/containers)

ariasuni commented 1 year ago

Well in general I don’t see the point, but in exa we use Vagrant for tests involving specific directory structures, locales, etc. I wanted to transition the Vagrantfile to a Dockerfile to be able to run these «xtests» that already exist, but I didn’t have the time. That would be great to have that!

AgustinRamiroDiaz commented 1 year ago

Awesome! I'll work on it :D

AgustinRamiroDiaz commented 1 year ago

Hey @ariasuni!

quick question: are Vagrant tests passing with the latest master commit?

I don't see any CI with Vagrant to check this, and couldn't make Vagrant work in my PC :(

I have been able to do a PoC of the Dockerfile and I could execute the tests, but there's a lot of formatting errors. I want to know if this errors are a misconfiguration of mine or if they are actually failing in master

ariasuni commented 1 year ago

Closing this since exa is unmaintained (see https://github.com/ogham/exa/issues/1243), you should take a look at the active fork eza (an alternative strategy has been used for tests).