search

ogham / exa

A modern replacement for ‘ls’.
https://the.exa.website/
MIT License
23.61k stars 659 forks source link

Not displaying size correctly when in /dev folder #601

Open CarlsenSmart opened 4 years ago

CarlsenSmart commented 4 years ago

If you execute exa -lh in the /dev folder (running Ubuntu 18) you will see that it does not show the size of the folders. Maybe has something to do with the Major/Minor details being shown instead in the Size column for devices ? :) I can see that only the Major number is highlighted, that is why I am thinking it has something to do with it.

Here is an example from my own machine: image

CarlsenSmart commented 4 years ago

My bad .. I am new to exa (just downloaded it) and I only downloaded it since I wanted headers for the Major/Minor details, so I did not notice before now that exa never shows the size of a directory.

But maybe the issue could be about that you are calling it the Size since major and minor number is not saying anything about the size. They are talking about which drivers are associated to the file :) Again sorry for not notices that You are not showing size of folders before now.

c3st7n commented 4 years ago

This choice is specifically called out in the source: https://github.com/ogham/exa/blob/master/src/fs/file.rs#L305

Is there any appetite to split this out into a seperate column, if so I am happy to knock up a PR.

CarlsenSmart commented 4 years ago

It could be cool if it was two separated columns, because then it would make more sense (at least for me), but to be honest if it takes too much of your time for that little of a detail, I don't want to require that from you :)