ogiogiovictor / Final-Group-Capstone-Reservation-Rails

Rentomotors is an app that enables users to reserve cars for their personal benefits for a certain period of time. It built with Ruby on Rails and React Js used as frontend.
MIT License
0 stars 0 forks source link

KANBAN BOARD #25

Open ogiogiovictor opened 1 year ago

ogiogiovictor commented 1 year ago

Project Requirement

Github Link : https://github.com/ogiogiovictor/Final-Group-Capstone-Reservation-Rails We have three(3) persons in the team

image

Updated Kanban Board Based on Request image

vichuge commented 1 year ago

Hi dear student,

Good job so far! You still need to work on some issues to prepare your project for the final evaluation, but you are almost there!

mario_ladders

Suggested changes

Check the comments under the review.

  1. Please add an in review column on the project
  2. The points diff between @fernando-silvabr66 and @MrOmachi is 5 points, try to have no more than 5 point diff between each person on the team (preferably 3 or less, according to guidelines no more or equal to 5)

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Meltrust commented 1 year ago

Hi @fernando-silvabr66 ,

Wow, you did it 🎉

Brilliant

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗️

Well done!

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Meltrust commented 1 year ago

note: This is a new first review.

Hi @vichuge,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight:

You can do it

Required Changes ♻️

According to the project requirements:

image

However, task #26 does not contain any description:

image

Therefore:

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

MrOmachi commented 1 year ago

Thank you for the review!

description has been added.

Meltrust commented 1 year ago

Hi @vichuge,

Wow, you did it 🎉

Brilliant

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗️

Well done!

Congratulations! 🎉

To highlight

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.