ogkalu2 / comic-translate

Desktop app for automatically translating comics - BDs, Manga, Manhwa, Fumetti and more in a variety of formats (Image, Pdf, Epub, cbr, cbz, etc) and in multiple languages.
Apache License 2.0
1.06k stars 96 forks source link

New update with saving the project #143

Open TaunT opened 1 month ago

TaunT commented 1 month ago

@ogkalu2 First of all, thanks for the continued work on the functionality!

Some questions:

1) There is still not enough functionality to be able to manually clean/correct the image with an external program. The project is saved in "сtpr" - is this a zip archive? I unpacked it, edited the image and packed it again) But not everyone can do this. And why use msgpack inside if everything is archived anyway, can't you just use json?

2) BUG When loading a project or navigating through images, some blocks break their condition, apparently they are not always saved. image

3) BUG If you save a project while working on an image (digitization has taken place, but there is no rendering), then when loading the project one image is broken and is not displayed. Although it is in the archive of the saved project. Now the project is broken. Apparently, the link to the temporary file is saved, and not to the main image.

FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\9EF8~1\\AppData\\Local\\Temp\\tmpf0wgw7uf\\unique_images\\RCO003.jpg'

image

I created this temporary directory and put the file there. It was displayed inside the program, but for some reason the blocks were from the first image. image

Another observation - when I started working with the second image and saved it, the third image became broken, that is, when saving, the next one breaks

3) there is still not enough highlighting in the top menu of the last action, on which step we are now

4) there are not enough navigation buttons between blocks. This is very useful at the stage of automatic block creation, to find "parasitic" extra blocks in the picture, which are simply part of the picture. Well, and then it is convenient to switch.

lawrenz1 commented 1 month ago

There is still not enough functionality to be able to manually clean/correct the image with an external program. The project is saved in "сtpr" - is this a zip archive? I unpacked it, edited the image and packed it again) But not everyone can do this.

I think you can export as zip, cbz, cb7, pdf, epub format which external programs can read and then import in the same format once you are done

TaunT commented 1 month ago

@lawrenz1 You didn't get it) the point was about a new feature - saving the whole project into one file - with blocks, recognized text, translation, cleared image, rendered text, all fonts with their size and color. image

TaunT commented 1 month ago

@ogkalu2 The tool for clearing filled segments has become worse. Previously, it simply erased the part you moved it over, but now it erases a small square block, so that the letter is exposed entirely. But I only needed to remove a little excess coloring.

upd: The new mode of the "erase brush strokes" tool is very bad! Please roll back the change.

ogkalu2 commented 1 month ago

Just wanted to say i've seen this. I'll work on it in my free time. Very busy now.

ogkalu2 commented 3 weeks ago

@ogkalu2 The tool for clearing filled segments has become worse. Previously, it simply erased the part you moved it over, but now it erases a small square block, so that the letter is exposed entirely. But I only needed to remove a little excess coloring.

upd: The new mode of the "erase brush strokes" tool is very bad! Please roll back the change.

I didn't change how clearing filled segments work though ? What's wrong with the new erase ?

TaunT commented 3 weeks ago

After the "text segment" step, there are many separate red rectangles. Previously, when using the "erase tool", it was possible to erase part of the rectangle, but now it is deleted entirely, even if it is slightly touched. If the corner of the square of the filled letter goes to the border of the bubble, then previously it was possible to erase this corner, but now the entire letter is deleted and it must be re-painted manually.

ogkalu2 commented 3 weeks ago

After the "text segment" step, there are many separate red rectangles. Previously, when using the "erase tool", it was possible to erase part of the rectangle, but now it is deleted entirely, even if it is slightly touched. If the corner of the square of the filled letter goes to the border of the bubble, then previously it was possible to erase this corner, but now the entire letter is deleted and it must be re-painted manually.

Okay. I'll look into that

TaunT commented 3 weeks ago

Here is an example, when you go a little on the letters and a large block is immediately cleared

https://github.com/user-attachments/assets/ebf288c4-b6ff-4e3a-87bd-c64ec1fc681a

ogkalu2 commented 3 weeks ago

Here is an example, when you go a little on the letters and a large block is immediately cleared

default.mp4

This has been fixed now

ogkalu2 commented 1 week ago

@ogkalu2 First of all, thanks for the continued work on the functionality!

Some questions:

  1. There is still not enough functionality to be able to manually clean/correct the image with an external program. The project is saved in "сtpr" - is this a zip archive? I unpacked it, edited the image and packed it again) But not everyone can do this. And why use msgpack inside if everything is archived anyway, can't you just use json?
  2. BUG When loading a project or navigating through images, some blocks break their condition, apparently they are not always saved. image
  3. BUG If you save a project while working on an image (digitization has taken place, but there is no rendering), then when loading the project one image is broken and is not displayed. Although it is in the archive of the saved project. Now the project is broken. Apparently, the link to the temporary file is saved, and not to the main image.
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\9EF8~1\\AppData\\Local\\Temp\\tmpf0wgw7uf\\unique_images\\RCO003.jpg'

image

I created this temporary directory and put the file there. It was displayed inside the program, but for some reason the blocks were from the first image. image

Another observation - when I started working with the second image and saved it, the third image became broken, that is, when saving, the next one breaks

  1. there is still not enough highlighting in the top menu of the last action, on which step we are now
  2. there are not enough navigation buttons between blocks. This is very useful at the stage of automatic block creation, to find "parasitic" extra blocks in the picture, which are simply part of the picture. Well, and then it is convenient to switch.

Can you try creating and loading new projects and see if bugs 2 and 3 still persist ?

TaunT commented 1 week ago

@ogkalu2 The second bug is still there. Here is the project file (changed to zip to upload) - I load it, three crooked blocks. I align them, save, load again - they have the old size. [RCO123.zip](https://github.com/user-attachments/files/17552115/RCO123.zip)

image

TaunT commented 1 week ago

the third bug is fixed, thanks!

ogkalu2 commented 1 week ago

the third bug is fixed, thanks!

Alright. Can you send me an Image that causes this issue so I can do my own testing.

TaunT commented 1 week ago

Ok) But it doesn't depend on the picture, I have this on any of them.

RCO123

ogkalu2 commented 6 days ago

Ok) But it doesn't depend on the picture, I have this on any of them.

RCO123

This has been fixed now. It also works backwards so old projects should load correctly now

ogkalu2 commented 6 days ago

For your first question. Originally this used yaml and saved all the images directly to file but that was godawfully slow so i looked for the fastest thing i could use without having to set up a separate prototype file and that was message pack. It was much faster but still too slow for my liking. Eventually i moved to saving the images in a folder instead which increased speed a lot but by then i saw no need to change file formats.

TaunT commented 6 days ago

@ogkalu2 Thank you very much! The only bug that is still bothering me is this one https://github.com/ogkalu2/comic-translate/issues/107 I tried to fix it myself, but it didn't work