ognus / wallet-address-validator

Useful library for validation of Bitcoin, Litecoin, Ethereum and other cryptocoin addresses
MIT License
261 stars 129 forks source link

bitcoincash #27

Open tomochandv opened 6 years ago

tomochandv commented 6 years ago

bitcoincash new address check possible?

bitcoincash:qrg9za3nl6kklh9ppxla8qa8ye5grpk3755n49q705

i test it .fail.

ognus commented 6 years ago

@zeppelin do you still plan to work on validation for new bitcoincash addresses?

tomochandv commented 6 years ago

yes. i validate old address and new address both use it.

zeppelin commented 6 years ago

@ognus Yes, but with some delay. Something urgent came up on my project, had to allocate my resources elsewhere. Hopefully I can resume work next week!

ognus commented 6 years ago

@zeppelin Sounds great and thank you for letting me know. Good luck with your project :)

tomochandv commented 6 years ago

Thank you so much. I'll be waiting.

nicman23 commented 6 years ago

hello, sorry for bothering you, is this resolved?

ognus commented 6 years ago

@nicman23 it is not

zeppelin commented 6 years ago

@nicman23 @ognus Unfortunately I didn't have any time to work on this. I suggest you either roll back the feature than have it incomplete. Also can't tell an ETA because I've very tight deadlines in the coming weeks, so I can't work OSS at all at the moment... :(

I'll definitely need this in the future, it's just more urgent things came in front.

nicman23 commented 6 years ago

do you accept bounties?

ognus commented 6 years ago

@zeppelin Thank you for the update! I will try to do some research on the new BCH addresses format and hopefully finish you work. If you have any links handy in relation to the new addresses, feel free to let me know :) Either way, thank you.

ognus commented 6 years ago

@nicman23 what do you mean? Accepting money through something like https://www.bountysource.com/? To be honest I never thought about it.

nicman23 commented 6 years ago

yes something like that

ghost commented 6 years ago

In case anyone finds this helpful:

Is there an official CashAddr specification for developers?

Yes, here.

source: CashAddr Addresses Are Here

camslice commented 5 years ago

Unfortunately BCH has 3 types of addresses: legacy, bitpay, cash

We could add this library as a dependency? https://github.com/bitcoincashjs/cashaddrjs

manemao commented 4 years ago

I dont know it's a new issue or related to this one but for now any bch address validation failing with this libraray.

manemao commented 3 years ago

Unfortunately BCH has 3 types of addresses: legacy, bitpay, cash

We could add this library as a dependency? https://github.com/bitcoincashjs/cashaddrjs

cashaddrjs working well

kuda2012 commented 1 year ago

Was this issue resolved for BCH addresses failing?

manemao commented 1 year ago

@kuda2012 last commit on this repository is for 4 years ago. nothing happened here for sure