ETH & XRP testnet addresses are being validated as valid mainnet addresses

ognus / wallet-address-validator

Useful library for validation of Bitcoin, Litecoin, Ethereum and other cryptocoin addresses

MIT License

264 stars 129 forks source link

ETH & XRP testnet addresses are being validated as valid mainnet addresses #46

Open camslice opened 6 years ago

camslice commented 6 years ago

When passing the 'prod' flag and attempting to validate against the mainnet for both ETH and XRP, the following testnet addresses are returned as valid:

ETH testnet addresses: 0xEf2C700943B7BD72Cae6C938188dD1aC9537b228 0xD1D1BAA591933BcA66F5e99be8843a0B7Df9f334

XRP testnet addresses: r479Q1f3xm4VfAxNLoXAVKhSN1E8FArztD rDHEEzqZ4EhqN1ij1w5xhbx55vwLjhQZgo

liamaharon commented 4 years ago

There is no difference between Etheruem mainnet and testnet addresses. You'll probably find the same thing for XRP addresses.

camslice commented 4 years ago

I did notice this. Could be good to add this to your documentation