search

ognus / wallet-address-validator

Useful library for validation of Bitcoin, Litecoin, Ethereum and other cryptocoin addresses
MIT License
263 stars 128 forks source link

Add support for Monero (XMR) stagenet addresses #62

Open septagram opened 5 years ago

septagram commented 5 years ago

Aside from prod and testnet, Monero also has stagenet which is essentially the same thing most other cryptocurrencies call "testnet". In Monero, however, testnet is the "experimental" network and blockchain where things get released long before mainnet.

septagram commented 5 years ago

It says "unknown repository" because I deleted my fork so I can create a similar pull request at christsim/multicoin-address-validator, which appears to be better maintained at the moment :(

aaronovz1 commented 5 years ago

This also needs to include validation of subaddresses. See https://github.com/monero-project/monero/blob/master/src/cryptonote_config.h for the prefixes.

septagram commented 5 years ago

Thanks for the pointer, will try to implement that, it's definitely necessary.

However, the original code did did not include subaddress validation as well, so IMHO subaddress validation can be added in a separate pull request.