search

ogobrecht / d3-force-apex-plugin

Oracle APEX Region Type Plugin: D3 Force Network Chart
https://ogobrecht.github.io/d3-force-apex-plugin
MIT License
24 stars 9 forks source link

Link labels: Long texts are clipped on both sides when they are too long - should only be clipped at the end #49

Closed ogobrecht closed 3 years ago

ogobrecht commented 3 years ago

See here for some help: https://alligator.io/svg/textpath/

Note: Issue was opened for @apex-michael

apex-michael commented 3 years ago

Hi,

I would say that this works for me. Great.

One small thing is that, if the length of the link (distance between nodes) is being reduced so there is not enough room for the label, then it starts clipping the label from the center of the node not from the circumference. I.E. some label text ends up inside the node.

But I also understand that for this to behave differently, you need to check the radius of every node and that may take some time if there are thousands of nodes and several different node radius. And as I said, the behavior after fix of #49 is fine for me :-)

ogobrecht commented 3 years ago

Hi Michael,

thank you for your feedback and the testing. I have published the new release 3.1.2

Best regards Ottmar

apex-michael commented 2 years ago

Chrome Browser specific issue. Hi Ottmar, now that more people are using it, we have seen a browser specific issue with this. In Firefox (101.0.1 (64-bit)) all works fine. But in Chrome (103.0.5060.66 (Official Build) (64-bit)) the label for the link is detached and displays in top left corner, if it is clipped while being in the angle of -PI/2 to PI/2 see attached description. Chrome Browser issue.pdf

ogobrecht commented 2 years ago

Hi Michael,

sorry for my very late response. I need a little bit of time to dig into the issue. Thank you for the detailed issue description. I will you keep updated.

Best regards Ottmar

apex-michael commented 2 years ago

Thanks Ottmar,

Really appreciate that.

In a week or two most of the people will have acces to see the graphs, so I assume at least some will use chrome.

As I said, really appreciate your effort on this.

Best Regards

Michael

On 21 Jul 2022, at 20.15, Ottmar Gobrecht @.***> wrote:



Hi Michael,

sorry for my very late response. I need a little bit of time to dig into the issue. Thank you for the detailed issue description. I will you keep updated.

Best regards Ottmar

— Reply to this email directly, view it on GitHubhttps://github.com/ogobrecht/d3-force-apex-plugin/issues/49#issuecomment-1191842938, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWAML2BP7E6L3XHH4QH7O2DVVGOSPANCNFSM5FTDVS3Q. You are receiving this because you were mentioned.Message ID: @.***>