search

ogre-run / miniogre

Automate the management of software dependencies with AI, to ensure your Python code runs on any computer.
https://docs.ogre.run
Apache License 2.0
43 stars 6 forks source link

Analyze python notebook files `.ipynb` to extract requirements #3

Closed wilderlopes closed 4 months ago

wilderlopes commented 7 months ago

Problem

Several python projects, especially in data science, use .ipynb files. Currently, those files are not taken into account when retrieving the imported packages. This leads to inacuracies in the final list of requirements.

Proposed solution

Convert .ipynb into .py and then use the existing method extract_requirements_from_code to retrieve the dependencies.

Aftabby commented 7 months ago

Hi @wilderlopes ,

I hope you're doing well. I noticed that this issue is currently assigned to you, and I'm interested in taking on the task myself. Since it seems like a straightforward issue, I believe I can handle it independently.

Would you mind if I take over this issue and work on it solo? I'm eager to contribute and confident in my ability to resolve it efficiently. Please let me know if you're okay with reassigning the issue to me.

Thank you.

wilderlopes commented 7 months ago

Hey @Aftabby,

Yes, please, go ahead. Let me know if you need assistance.

Aftabby commented 7 months ago

Hello @wilderlopes , Can you please review the code to check if everything is alright? Thanks.

wilderlopes commented 4 months ago

Hi @Aftabby. After checking your pull request #8 (see comments there), I noticed there were some issues that needed fixing. In the process of fixing it, I realized it was better to take a totally new approach.

Implemented in https://github.com/ogre-run/miniogre/commit/88067d9a4bd17a4ba51e99c0cff6d921cc2677a6