search

ogri-la / strongbox

a World of Warcraft Addon Manager aimed at Linux players
GNU Affero General Public License v3.0
167 stars 7 forks source link

Some addons not recognized #231

Closed perara closed 3 years ago

perara commented 3 years ago

Describe the bug When downloading some addons, strongbox cannot find them

To Reproduce Steps to reproduce the behavior. For example:

  1. Search for loggerhead
  2. Install Selected Logs give me `2021-01-03 18:26:14.500 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'loggerhead' (classic) on curseforge

Not quite sure why this happens, but it seems like you are lowercasing the name, while this specific addon requires camelcased name?

I've not confirmed this, but the following addons also struggles with this:

2021-01-03 18:26:07.881 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'auctionator' (classic) on curseforge
2021-01-03 18:26:07.881 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'bagnon' (classic) on wowinterface
2021-01-03 18:26:07.886 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'gathermate2' (classic) on curseforge
2021-01-03 18:26:07.886 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'gathermate2_data' (classic) on curseforge
2021-01-03 18:26:07.889 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'letmecast' (classic) on wowinterface
2021-01-03 18:26:07.890 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'omnicc' (classic) on wowinterface
torkus commented 3 years ago

Thanks for opening a ticket, @perara .

Each addon directory you have also has a 'game track'. The game track is either strictly 'retail' or 'classic', or, less strictly 'any, prefer retail' or 'any, prefer classic'. This is a dropdown that can be found next to the addon directory dropdown.

I'm guessing you either have an addon directory with mixed retail/classic addons or your game track has changed accidentally and it's now looking for classic versions of addons that were installed as retail (and not finding them).

perara commented 3 years ago

Hi, you are correct. In my specific case, LoggerHead is specifically a Retail addon. Perhaps it would be possible to identify (at least for curse forge?) or give some kind of feedback to me as an end-user that I'm trying to install addons of the wrong game version. Currently, it's not quite intuitive.

torkus commented 3 years ago

give some kind of feedback to me as an end-user that I'm trying to install addons of the wrong game version

The message:

no release found for 'addon-name' (gametrack) on addon-host

Seems pretty straightforward to me. Do you have some idea of what would be a more intuitive solution? I could perhaps measure the number of addons that failed to find a release and, if it's a high proportion, prompt you (the user) if you're on the right game track?

perara commented 3 years ago
  1. When I do a search (LoggerHead) and press "install selected" I'm navigated back to Installed without any feedback if the install was successful or not. The only feedback received is, as you mention no release found for 'addon-name' (gametrack) on addon-host which is well hidden in the console, it is also not shown in the "gui console". Attached is the log for attempting to install loggerhead. Yes, the error is there, considering the log has a bit of history and all of that other info gets printed, it's not that clear to me what the error actually is. 
    2021-01-04 07:25:53.351 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'loggerhead' (classic) on curseforge
2021-01-04 07:25:53.356 linux-desktop WARN [strongbox.toc:193] - failed to find .toc file: /home/per/Games/Gamefiles/World of Warcraft/_classic_/Interface/AddOns/cache
2021-01-04 07:25:53.360 linux-desktop WARN [strongbox.toc:132] - addon with no "Title" value found: /home/per/Games/Gamefiles/World of Warcraft/_classic_/Interface/AddOns/ExtendedCharacterStats
2021-01-04 07:25:53.372 linux-desktop WARN [strongbox.toc:193] - failed to find .toc file: /home/per/Games/Gamefiles/World of Warcraft/_classic_/Interface/AddOns/themes
2021-01-04 07:25:53.378 linux-desktop WARN [strongbox.nfo:130] - ignoring 'Indicators': addon directory contains a .git/.hg/.svn folder
2021-01-04 07:25:53.380 linux-desktop INFO [strongbox.core:514] - loading installed addons: /home/per/Games/Gamefiles/World of Warcraft/_classic_/Interface/AddOns
2021-01-04 07:25:53.382 linux-desktop WARN [strongbox.toc:193] - failed to find .toc file: /home/per/Games/Gamefiles/World of Warcraft/_classic_/Interface/AddOns/cache
2021-01-04 07:25:53.389 linux-desktop WARN [strongbox.toc:132] - addon with no "Title" value found: /home/per/Games/Gamefiles/World of Warcraft/_classic_/Interface/AddOns/ExtendedCharacterStats
2021-01-04 07:25:53.398 linux-desktop WARN [strongbox.toc:193] - failed to find .toc file: /home/per/Games/Gamefiles/World of Warcraft/_classic_/Interface/AddOns/themes
2021-01-04 07:25:53.403 linux-desktop WARN [strongbox.nfo:130] - ignoring 'Indicators': addon directory contains a .git/.hg/.svn folder
2021-01-04 07:25:53.405 linux-desktop INFO [strongbox.core:514] - loading installed addons: /home/per/Games/Gamefiles/World of Warcraft/_classic_/Interface/AddOns
2021-01-04 07:25:53.405 linux-desktop INFO [strongbox.core:692] - matching 51 addons to catalogue
2021-01-04 07:25:54.028 linux-desktop INFO [strongbox.core:708] - num installed 51 , num matched 27
2021-01-04 07:25:54.028 linux-desktop WARN [strongbox.core:711] - you need to manually search for them and then re-install them
2021-01-04 07:25:54.031 linux-desktop WARN [strongbox.core:712] - failed to find 23 addons in the 'full' catalogue: bagnon-config, titan-panel-classic-[|cffeda55fclock|r]-|cff00aa001.2.4.11305|r, shadowed-uf-(options), zygor-guides-viewer-classic, bagnon-void-storage, titan-panel-classic-[|cffeda55fxp|r]-|cff00aa001.2.4.11305|r, titan-panel-classic-[|cffeda55floottype|r]-|cff00aa001.2.4.11305|r, e|cffaeaeddfficient|r-|cffff0000mage|rdecurse, titan-panel-classic-[|cffeda55fbag|r]-|cff00aa001.2.4.11305|r, bagnon-guild-bank, titan-panel-classic-[|cffeda55fregen|r]-|cff00aa001.2.4.11305|r, titan-panel-classic-[|cffeda55frepair|r]-|cff00aa001.2.4.11305|r, bagbrother, scrap-merchant, titan-panel-classic-[|cffeda55flocation|r]-|cff00aa001.2.4.11305|r, titan-panel-classic-[|cffeda55fgold|r]-|cff00aa001.2.4.11305|r, scrap-options, titan-panel-classic-[|cffeda55fvolume|r]-|cff00aa001.2.4.11305|r, m|cffaeaeddonolith|r-|cffff0000dkp|r, ahmaster, titan-panel-classic-|cff00aa001.2.4.11305|r, titan-panel-classic-[|cffeda55fperformance|r]-|cff00aa001.2.4.11305|r, titan-panel-classic-[|cffeda55fammo|r]-|cff00aa001.2.4.11305|r
2021-01-04 07:25:54.031 linux-desktop INFO [strongbox.core:774] - checking for updates
2021-01-04 07:25:54.033 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'auctionator' (classic) on curseforge
2021-01-04 07:25:54.034 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'bagnon' (classic) on wowinterface
2021-01-04 07:25:54.038 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'gathermate2' (classic) on curseforge
2021-01-04 07:25:54.039 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'gathermate2_data' (classic) on curseforge
2021-01-04 07:25:54.041 linux-desktop WARN [strongbox.catalogue:60] - no release found for 'letmecast' (classic) on wowinterface
2021-01-04 07:25:54.047 linux-desktop INFO [strongbox.core:779] - 27 addons checked, 0 updates available
2021-01-04 07:26:16.807 linux-desktop INFO [strongbox.utils:513] - opening URL: https://www.curseforge.com/wow/addons/loggerhead
2021-01-04 07:26:16.947 linux-desktop INFO [strongbox.utils:513] - opening URL: https://www.curseforge.com/wow/addons/loggerhead
Opening in existing browser session.
Opening in existing browser session.
  2. My suggestion would be to adopt no release found for 'addon-name' (gametrack) on addon-hostto the GUI log and append "Ensure that the add-on is supported in the current game version", with FATAL/CRITICAL (red) background, to clearly show that the user action is faulty.

(3). I'm not sure how you are determining addon version/game version, but if this is obtainable from scraping all sources, maybe add a column that identifies which versions are supported

torkus commented 3 years ago

hi @perara , long time since an update on this, sorry about that.

Points 1 and 2 have now been addressed. If any warnings or errors are generated while installing an addon a popup dialog with the details will be displayed.

Log messages are now tied to addons wherever possible so the 'no release found' message has context.

I've also tucked the log pane into it's own tab and given addons a status column with a coloured tick, dash or cross to indicate their general healthiness. You can click this status indicator to go to the addon detail page and view more detailed information for that addon including it's own logger.

Also, if 'strict' mode is disabled and a mismatched update is available, for example, if a classic release is available for an addon while in 'retail' mode, there will be a warning against that addon.

Your final point is difficult as strongbox doesn't know the available releases or their supported modes before going out to look for them. I think more can be done with 'releases' in general within strongbox, grouping them up and opting-in to no-lib and alpha or beta versions, but that doesn't have priority at the moment. I'll bump it up the list but can't guarantee when it will get attention.

I'm closing this ticket for now but I'm always open to more feedback including features or improvements you'd like to see. Just open a ticket and I'll take a look.

Thanks again for opening a ticket.

perara commented 3 years ago

YOu have come a long way with this addon. Generally, you have fixed all my concerns. Good job and keep ut up, its a awesome addon, and best of all it works flawless on Linux :)

Thanks for your work!