torkus
commented
3 years ago - [x] detail pane filters log messages by addon (directory + source + source-id)
- [x] detail pane filterable by severity (debug, info, warn, err)
- how to filter by 'debug' when we run at 'info'? perhaps only display 'debug' if 'debug' messages are available.
- same for 'warn' and 'error'? no, we don't want nav jumping around. 'debug' is the first/last item and won't significantly affect the position of the others
- how to filter by 'debug' when we run at 'info'? perhaps only display 'debug' if 'debug' messages are available.
- [x] dedicated log tab has buttons to filter by severity (debug, info, warn, err)
- [x] detail pane displays per-addon log messages
- [x] detail pane displays number of errors or warnings next to severity filter
- [x] log pane has a consistently sized and relevant message when empty
- [x] ensure all per-addon logging now has the correct meta attached to it
- [ ] ~message in log lines wraps to available width rather than truncation~
- may not be possible. Have a play with the code vlaad came up with
- it works but styling is messed up because it is using 'text' instead of a 'label'. Doesn't seem possible to have a 'label' wrap at the moment.
- [x] highlight log tab or status bar or something when there are non-addon errors or warnings
- does it have to be non-addon? what are we really trying to achieve here?
- user should be made aware that all is not right. if this is present in an addon's uber-button then app-level errors still need highlighting
- users may not be able to fix warnings but errors should be preventable/reportable
- [x] double clicking a row in log pane that has an addon attached opens detail
- [x] bug, regression, NPE deleting an addon while its tab is open
- happens when we can't find an addon because our search is too strict given how much we know about an addon
- reproducible with: install addon, open addon detail, click delete.
- is not reproducible with: open addon detail from search, click install, click delete.
- [x] bug, regression, source column displayed in app notice logger
- [x] logging, console logging now relies on associated addon for context
- [x] remove 'host' from log line
- [x] add addon dirname or label - whatever I'm using for the 'source' column
- [ ] ~bug, I should be able to re-install a pinned addon if the pinned release is available, but I'm getting an error~
- "refusing to install addon that will overwrite a pinned addon"
- this is actually a bit more involved than it first looks. shifting to it's own ticket
- does it have to be non-addon? what are we really trying to achieve here?
- [x] review
- [x] update changelog