torkus
commented
3 years ago # timing
## data.json v1.0.0
strongbox.main=> (strongbox.profiling/profile-read-validate-catalogue)
15453 addons loaded and validated
nil
pId nCalls Min 50% ≤ 90% ≤ 95% ≤ 99% ≤ Max Mean MAD Clock Total
:op 50 524.37ms 528.17ms 540.41ms 542.53ms 547.19ms 547.19ms 531.15ms ±1% 26.56s 100%
:catalogue 50 265.88ms 267.54ms 279.19ms 281.07ms 283.94ms 283.94ms 269.80ms ±1% 13.49s 51%
:catalogue:load-json-file 50 265.86ms 267.53ms 279.17ms 281.06ms 283.92ms 283.92ms 269.78ms ±1% 13.49s 51%
:catalogue:validate 50 250.39ms 259.29ms 272.18ms 275.65ms 278.56ms 278.56ms 261.34ms ±2% 13.07s 49%
Accounted 1.11m 251%
Clock 26.56s 100%
---
## data.json v2.4.0
strongbox.main=> (strongbox.profiling/profile-read-validate-catalogue)
15453 addons loaded and validated
nil
pId nCalls Min 50% ≤ 90% ≤ 95% ≤ 99% ≤ Max Mean MAD Clock Total
:op 50 443.13ms 447.31ms 461.87ms 471.30ms 563.38ms 563.38ms 452.96ms ±2% 22.65s 100%
:catalogue:validate 50 247.67ms 255.35ms 270.44ms 274.87ms 297.88ms 297.88ms 258.28ms ±2% 12.91s 57%
:catalogue 50 189.69ms 190.71ms 203.12ms 207.11ms 265.22ms 265.22ms 194.65ms ±3% 9.73s 43%
:catalogue:load-json-file 50 189.67ms 190.68ms 203.10ms 207.09ms 264.82ms 264.82ms 194.62ms ±3% 9.73s 43%
Accounted 55.03s 243%
Clock 22.65s 100%
## data.json v2.4.0, orchestra 2021.01.01-1
strongbox.main=> (strongbox.profiling/profile-read-validate-catalogue)
15453 addons loaded and validated
nil
pId nCalls Min 50% ≤ 90% ≤ 95% ≤ 99% ≤ Max Mean MAD Clock Total
:op 50 447.02ms 452.11ms 468.57ms 473.88ms 561.01ms 561.01ms 457.17ms ±2% 22.86s 100%
:catalogue:validate 50 253.56ms 258.97ms 275.54ms 281.98ms 296.08ms 296.08ms 262.51ms ±2% 13.13s 57%
:catalogue 50 189.44ms 191.18ms 201.86ms 204.80ms 264.68ms 264.68ms 194.63ms ±3% 9.73s 43%
:catalogue:load-json-file 50 189.42ms 191.15ms 201.84ms 204.77ms 264.30ms 264.30ms 194.60ms ±3% 9.73s 43%
Accounted 55.45s 243%
Clock 22.86s 100%
## data.json v2.4.0 + bumps
strongbox.main=> (strongbox.profiling/profile-read-validate-catalogue)
15453 addons loaded and validated
nil
pId nCalls Min 50% ≤ 90% ≤ 95% ≤ 99% ≤ Max Mean MAD Clock Total
:op 50 446.12ms 458.12ms 480.94ms 487.86ms 493.77ms 493.77ms 460.53ms ±2% 23.03s 100%
:catalogue:validate 50 254.47ms 259.62ms 275.96ms 283.28ms 292.27ms 292.27ms 263.36ms ±3% 13.17s 57%
:catalogue 50 190.69ms 193.65ms 206.49ms 214.73ms 214.97ms 214.97ms 197.15ms ±3% 9.86s 43%
:catalogue:load-json-file 50 190.66ms 193.63ms 206.47ms 214.71ms 214.95ms 214.95ms 197.13ms ±3% 9.86s 43%
Accounted 55.91s 243%
Clock 23.03s 100%
about an ~80ms improvement on reading and validating the json.
some minor speed improvements to
data.json~but also new errors that need extra handling~ my test fixtures were bad! a missing comma snuck in and was copied and pasted to another fixture.[x] review
[x] update CHANGELOG