changes the filename of downloaded zip files to include game track.

ogri-la / strongbox

a World of Warcraft Addon Manager aimed at Linux players

GNU Affero General Public License v3.0

169 stars 7 forks source link

changes the filename of downloaded zip files to include game track. #331

Closed torkus closed 2 years ago

torkus commented 2 years ago

addon, changed the filename of downloaded zip files to include game track. this is causing a cache hit for addons whose 'version' value is identical across game tracks. doesn't affect those with 'clear zip files' preference turned on. doesn't affect addons that embed the game track in the addon name or version value, like 'leatrix-plus-bcc--2-5-85.zip' or 'lunaunitframes--4-120-beta-tbc.zip'.
[ ] ...
[ ] review
[ ] update CHANGELOG

torkus commented 2 years ago

While fixing the other bug I realised this may not be as great as I thought now that we have multi-toc support.

A single addon downloaded as addon--1-2-3--classic that also supports retail and bcc will now be a cache miss when reinstalling - but that is pretty damn rare. And I have the impression switching between game tracks for addons is also pretty rare. Hrm. Still doesn't feel like the correct change to make.

torkus commented 2 years ago

there may be a problem here with filenames but I don't think this is the solution, closing.