Tukui.org support - Githubissues

AcidWeb commented 1 year ago

Hi,

Long, story short - https://www.tukui.org/ is abandoned. And due to reasons I'm not going to share here we can't fully shutdown it currently yet. But support for it should be dropped.

ElvUI and Tukui is available now over new api: https://tukui-api.acidweb.dev/v1/addons https://tukui-api.acidweb.dev/v1/addon/elvui

Few additional information:

url is unique and temporary. Can't be cached. User need to get own to download the package and it will be valid only for few minutes.
Output of API might be geolocalised. Players from US will get new versions sooner in some cases.
If for some reason you need Access-Control-Allow-Origin expanded - let me know.
Changelog is bare MD.
For the time being only these two addons will be available over new API.

torkus commented 1 year ago

Hi, @AcidWeb , thank you for opening a ticket, I appreciate it.

I'm going to need to see a statement to this effect hosted on https://www.tukui.org/ somewhere as I only know you as the author of Cursebreaker with no association to www.tukui.org .

Are you able to elaborate further regarding the unique URLs and new behaviour based on geographical region?

torkus commented 1 year ago

cc @layday

AcidWeb commented 1 year ago

@layday already knows. I'm a part of ElvUI team.

There is a realistic chance that there will not be any statement on site directly but expect news about it on our Discord server (https://discord.gg/xFWcfgE) when new site (that will not host addons other than ElvUI and Tukui) will be up. Entire matter is... dynamic. This ticket is just heads up.

Unique URLs - It is just a elaborate hotlink protection. It is not used in any form or shape to collect user data and track them.

Geolocation - Due to nature of WoW deployement cycle WoW US servers get new patches sooner than EU ones. Sometimes changes are so massive that ElvUI is totally broken by the patch and update is mandatory. This create a support issue. When we push update for US servers that release is not backward compatible. And every EU player that update his addons too soon breaks his UI. This problem is so common and create so much commotion during every patch day that in our new API we implemented mechanism to delay delivering information about new release for non-US users. We use data provided by CloudFlare to identify location of the user.

torkus commented 1 year ago

That's an interesting usecase for serving up different addon versions to different regions, I hadn't considered that before.

I'm a part of ElvUI team. There is a realistic chance that there will not be any statement on site directly [...] Entire matter is... dynamic.

I appreciate there might be some sort of drama going on but if you can't prove you're in control of tukui.org, and it sounds like you're not, then, from outside of all this, it's a little outrageous to be asked to drop support for it.

If tukui.org has become a security risk and is now serving up malware and this can be proven then I'll absolutely patch strongbox to disable support.

This ticket is just heads up.

Again, I appreciate that, and fwiw I'd like to trust you, but can't.

AcidWeb commented 1 year ago

I fully understand your approach and I'm not offended by it. Hopefully this matter will clear a little in upcoming days.

I will just share some facts: a) Server was not taken over. But I consider its shape as security risk due lack of maintenance. b) Site not longer provide reliable way to upload new addon releases. c) API itself is going up and down and there are no plans to fix it.

layday commented 1 year ago

Geolocation - Due to nature of WoW deployement cycle WoW US servers get new patches sooner than EU ones. [...]

I'm not sure if geolocation is the best idea here unless it's limited to Europe, but even then, there's nothing preventing someone residing in Europe from playing on US realms. A better approach might be to read the value of portal from WTF/Config.wtf and pass it on to the server (or lastAddonVersion if the game client is up to date).

AcidWeb commented 1 year ago

Obviously it is not something that will work always but it is good enough. I rather cut one legit player from EU that is playing on US server than handle 100 people on Discord that bricked their UI.

Plus this API will not be used only by clients - there are multiple ways to implement it better on client level.

(Also portal in WTF/Config.wtf have multiple edge cases and it might not be correct too - but that is out-of-scope for this ticket.)

AcidWeb commented 1 year ago

Tukui.org will be closed soon and all calls will be redirected to new domain that don't provide API.

Additionally I see I omitted one additional crucial piece of information - we don't plan to host any addons other than ElvUI and Tukui.

AcidWeb commented 1 year ago

Site was now replaced and API moved to: api.tukui.org

ogri-la / strongbox

Tukui.org support #405