search, sampling options

[torkus]

• [x] do not sample results when filtering by addon host alone
• [x] entire catalogue can be browsed unsampled
• [x] add tooltip to 'sample results' button, explaining it's purpose
• [x] ... what if this was a global toggle? right now it only affects unfiltered results and allows the entire catalogue to be browsed page by page, but if it were a global toggle, then any set of results > $results-per-page would be sampled down to a single page. You could type 'chat' or 'adi', get > 1 page of results but not show all of them.
  • I don't think this would be good default behaviour. You search, you expect a full set of navigable results. It could be an opt-in preference to always sample search results, but this feels like a rabbit hole I'm going down, making shit up to solve imaginary problems.
• [x] review
• [x] update CHANGELOG

[torkus]

ah!

--- FAILURES ---
{:file cli_test.clj, :line 266, :type :fail, :expected (-> (core/get-state) :search :results page-1 count (= 2)), :actual false, :message nil}
{:file cli_test.clj, :line 267, :type :fail, :expected (-> (core/get-state) :search :results page-2 count (= 2)), :actual false, :message nil}
{:file utils_test.clj, :line 596, :type :fail, :expected (= expected log-messages), :actual (not (= [current locks: #{} acquiring locks: #{:fn1 :foo} locks acquired: #{:fn1 :foo} current locks: #{:fn1 :foo} acquiring locks: #{:fn2 :foo} blocked! --fn1 executed-- releasing locks: #{:fn1 :foo} recurring in 10 ms, have waited 0 ms current locks: #{} acquiring locks: #{:fn2 :foo} locks acquired: #{:fn2 :foo} --fn2 executed-- releasing locks: #{:fn2 :foo}] [current locks: #{} acquiring locks: #{:fn1 :foo} locks acquired: #{:fn1 :foo} --fn1 executed-- current locks: #{:fn1 :foo} releasing locks: #{:fn1 :foo} acquiring locks: #{:fn2 :foo} blocked! recurring in 10 ms, have waited 0 ms current locks: #{} acquiring locks: #{:fn2 :foo} locks acquired: #{:fn2 :foo} --fn2 executed-- releasing locks: #{:fn2 :foo}])), :message nil}