Open ogrisel opened 5 years ago
As @NicolasHug noted, our min_samples_leaf
in pygbm is not correct. I would rather implement what LightGBM does, that is reject splits that would result in one of the child nodes having less than min_samples_leaf
.
You mean sklearn?
LightGBM is doing something very weird with min_sample_leaf
, it looks like it is ignored because of num_leaves
(see https://github.com/ogrisel/pygbm/issues/30#issuecomment-435138526)
@NicolasHug I think you used the wrong parameter name in that code.
Indeed. It's actually the pygbm handling of min_samples_leaf
that is broken. See: #34.
Possible culprits:
shrinkage
/learning_rate
min_samples_leaf
min_child_samples
See details in https://github.com/ogrisel/pygbm/issues/30#issuecomment-435091127.