search

ogrisel / pygbm

Experimental Gradient Boosting Machines in Python with numba.
MIT License
183 stars 32 forks source link

Remove constant_hessian_value? #89

Open NicolasHug opened 5 years ago

NicolasHug commented 5 years ago

I think we can drop the constant_hessian_value in the SplittingContext, and always assume the constant hessians value is 1. We just have to set the gradients value accordingly, to have consistent leaf values.

This is what we do for LS loss already. WDYT @ogrisel ?

ogrisel commented 5 years ago

As you wish. +0 to simplify the code a bit.