search

ogrodnek / csv-serde

Hive SerDe for CSV
Apache License 2.0
141 stars 80 forks source link

Let quoteChar accepts multiple characters in input #19

Closed Fleid closed 10 years ago

Fleid commented 10 years ago

See the issue here: http://stackoverflow.com/questions/24724801/hive-quotechar-serde-doesnt-work/25138124#25138124

It seems to me that quoteChar doesn't accept multiple characters in input. So when it is fed with 2 double quotes, it operates as if only one was provided.

ogrodnek commented 10 years ago

Thanks for the link to the problem/discussion....

The serde uses opencsv (http://opencsv.sourceforge.net/) to do the parsing, and it only works with a single character (http://opencsv.sourceforge.net/apidocs/au/com/bytecode/opencsv/CSVReader.html), so I'd say unfortunately it's unlikely we could support this without opencsv support...

The naming of the property as "quoteChar" is meant to express that it's a single character...

Fleid commented 10 years ago

As I expected :) Thanks a lot for your quick answer!