ogt / valid-url

Node module that provides URI validation functions
https://npmjs.org/package/valid-url
Other
215 stars 26 forks source link

Tests are only checking valid possibilities #4

Closed ogt closed 11 years ago

ogt commented 11 years ago

The tests aren't the original ones included in the perl code. The current version includes only a few positive tests - return true in every function is considered an acceptable result..

This means that we can't have confidence that the implementation/functionality of the module is consistent with the original.

Should have noticed when the original pull request came ....

ogt commented 11 years ago

Fixed in Release 1.0.6.