Open leal32b opened 1 year ago
Did you run tests to check if it works after the update?
I ran @leal32b 's branch locally:
780 passing (4s)
25 pending
MOCHA Tests completed successfully
I'm using Node 18.16.0 and ran into an issue (exists on master branch) with webpack. I was able to get everything to run with export NODE_OPTIONS=--openssl-legacy-provider
per this stack overflow.
Unfortunately this doesn't fix all the audit issues, there are @mikro-orm
dependencies that are vulnerable as well. When I try updating all the vulnerable dependencies
the tests fail for me with:
779 passing (4s)
25 pending
1 failing
1) Mikro ORM
can perform sample:
TypeError: builder.generateDdlCommands is not a function
at SchemaGenerator.dump (node_modules/@mikro-orm/knex/schema/SchemaGenerator.js:479:35)
at SchemaGenerator.getCreateSchemaSQL (node_modules/@mikro-orm/knex/schema/SchemaGenerator.js:68:31)
at SchemaGenerator.createSchema (node_modules/@mikro-orm/knex/schema/SchemaGenerator.js:29:32)
at mikroOrmSample (samples/mikro-orm/simple.ts:48:5)
at Context.<anonymous> (src/tests/mikro-orm-real.spec.ts:8:20)
It's not clear to me at a glance why this is failing.
Upgrading vulnerable devDependencies
as well causes even more tests to fail, but I don't think those are as meaningful. It's the actual dependencies that cause anything that depends on pg-mem
to fail npm audit
.