search

oguimbal / pg-mem

An in memory postgres DB instance for your unit tests
MIT License
1.98k stars 97 forks source link

fix: nothing should be returned when using on conflict do nothing (#353) #366

Closed nirweiner2 closed 10 months ago

nirweiner2 commented 11 months ago

when we use insert .... on conflict do nothing, and there is a conflict, nothing should be returned because no row was inserted. Fix the code accordingly. See issue #353

nirweiner2 commented 10 months ago

Hey @oguimbal, I would love to get it reviewed if possible.

nirweiner2 commented 10 months ago

Hey @oguimbal. Thank you very much for reviewing this. I have indeed made a mistake there, it got actually lost during the commit phase in git. I forced pushed the fix and hopefully it should be okay now.

oguimbal commented 10 months ago

Released as pg-mem@2.7.2

Thanks for spotting that !