search

ogx / Calculation2D

Extensible 2D image processing framework for C++
3 stars 0 forks source link

FlipImage adds a layer WTF? #97

Closed carasuca closed 12 years ago

themoob commented 12 years ago

5cc9f07fa7ac55ce016499a31117d5a57eb71fbe

carasuca commented 12 years ago

no, that's not an excuse...

carasuca commented 12 years ago

@themoob please make a separate project for testing, better yet don't commit it... there, I made it for you: f6e0a8063846f62c414d08bba1a17369af91de6e

carasuca commented 12 years ago

also please remove unrelated stuff from FlipImage, so I can finish it and use this

themoob commented 12 years ago

This was made for testing GUI, I don't care much about it. Why would it not add a layer? Anyway, whatever.

themoob commented 12 years ago

there, I made it for you: f6e0a80

No you didn't. We needed some sensible data inside to visualize it, that was the point, not adding an empty layer. Duh.

carasuca commented 12 years ago

No you didn't. We needed some sensible data inside to visualize it,

please use the new plugin stub for making your tests and don't push them to master (?!)

that was the point, not adding an empty layer. Duh.

don't care. Use it as you wish, just don't make others use it.

This was made for testing GUI, I don't care much about it.

me neither

Why would it not add a layer? Anyway, whatever.

yeah, whatever. It's just that these changes (which somebody does for testing, anyway, whatever) cause conflicts which prevent from pushing some resolution for other issues.

malleor commented 12 years ago

@carasuca has the point -- we should have created a test plugin and put test stuff there. Actually, we should have make a testing branch and keep stuff there, not making anyone pull irrelevant code. And we would have if we had time, I'm sure of that.

Let's drop the topic and leave this issue open until we back-out the changes for the plugin to be simplistic. (Actually, for the same sake we should move stub cmGeneric from the project to a separate project. Shall we open an issue?)

carasuca commented 12 years ago

@malleor yes, please do.