search

ogxd / gxhash

The fastest hashing algorithm 📈
https://docs.rs/gxhash
MIT License
700 stars 23 forks source link

Missing generic implementation or helper #10

Closed bill-myers closed 6 months ago

bill-myers commented 8 months ago

The crate seems to be missing a non-arch specific implementation, which forces anyone using gxhash to select another hash and use cfg directives to choose between them (obviously releasing non-specialized crates that only work on x86-64 and arm64 is not acceptable).

If the user selecting another hash is desired, then all GxHash types should take the other hash as a generic parameter, for user convenience.

ogxd commented 8 months ago

Yes you're right, it is important to provide a fallback. That's probably the 1st priority. Something can be done in the spirit of what is done for the crate ahash

ogxd commented 6 months ago

Closing as duplicate of https://github.com/ogxd/gxhash/issues/47