Change i64 seed to u64 - Githubissues

ogxd / gxhash

The fastest hashing algorithm 📈

https://docs.rs/gxhash

MIT License

798 stars 27 forks source link

Change i64 seed to u64 #78

Closed vlovich closed 5 months ago

vlovich commented 5 months ago

Breaking API change so would require a major bump, but all the other hashing libraries I've seen use u64 for the seed. The i64 comes from the x64 intrinsic only working with signed integers (arm has vdupq_n_u64). Could the external API be changed to u64 with the x64 backend doing a as i64 to convert?

A more motivating reason to break the major version would be to make the function more DOS resistant so if that's being done, maybe this could be done at the same time?

ogxd commented 5 months ago

Yes I agree, it would make more sense this way. Let's keep this as a side quest to DOS resistance improvements

ogxd commented 5 months ago

Done, will be released in v4