search

ogxd / gxhash

The fastest hashing algorithm 📈
https://docs.rs/gxhash
MIT License
799 stars 27 forks source link

Can we get an FFI for Python? #97

Open winstxnhdw opened 4 weeks ago

winstxnhdw commented 4 weeks ago

Happy to contribute, of course.

ogxd commented 3 weeks ago

Hello @winstxnhdw

Here there are signatures to FFI methods (I used these to benchmark GxHash against well-known C hash functions):
https://github.com/ogxd/gxhash/blob/main/ffi/src/lib.rs

I'm not super familiar with FFI for Python. From what I recall there are several approaches (Cython?) but my knowledge may be out-of-date. In any case, I don't think it would be very different considering that these FFI signatures are quite simple, but I don't think I would include any Python-related things into this repository. It would make more sense to do it in a separate repository (that you can make and maintain if you want, it's MIT licensed so you're 100% free to do whatever you want with it)

winstxnhdw commented 3 weeks ago

Hey, I don’t mind doing it in my own repository but considering you already have a C FFI in this repository, I thought it would be more consistent to have a Python one as well. If you’re worried about having Python code in the repository, worry not as Python bindings can be written in entirely Rust with PyO3 https://github.com/PyO3/pyo3