search

ogxd / project-curator

A convenient tool to help cleaning and maintaining Unity Projects 🧹✨
Do What The F*ck You Want To Public License
153 stars 27 forks source link

Use GUID type #22

Closed rhys-vdw closed 7 months ago

rhys-vdw commented 1 year ago

Hey @ogxd, your branch https://github.com/ogxd/project-curator/tree/refactoring is a good change, and I think should be merged as-is.

Would you mind merging it so I can do other fixes on top of it?

Also afterwards it would make sense to tag a release. I'd suggest going to 2.0.0 as this has breaking changes with 1.x.x

rhys-vdw commented 1 year ago

Scratch that, you'll need to restore this:

https://github.com/ogxd/project-curator/commit/37a409d4f54fdcb8e436bf0fe393e52b92a91bc1#diff-35c422567e0d60e2885c09e23612d0c9c9f95a32064cbea6f07525080158dfeeL176-R178

The GUID will be returned as 0 if invalid, so the check is still relevant.

An all-zero GUID denotes an invalid asset path.

https://docs.unity3d.com/ScriptReference/AssetDatabase.GUIDFromAssetPath.html

rhys-vdw commented 1 year ago

Okay, seeing the problem here. The UnityEditor.GUID type doesn't serialize haha. Assuming this is why you never merged this @ogxd?

rhys-vdw commented 1 year ago

Okay, I'm just going to maintain my own fork because I've got a bunch of changes I want merged. FYI I got serialization working. You'll need to cherry pick/copy if you want it:

https://github.com/EffortStar/project-curator/compare/EffortStar:3a4961f571ccf85eef0d15519086fb455b7224fe...EffortStar:d4d8ad1

rhys-vdw commented 7 months ago

Closed by #17