search

oh-my-fish / oh-my-fish-legacy

Oh My Fish!
MIT License
13 stars 2 forks source link

"omf list" displays error when not using a theme #496

Closed rholak closed 9 years ago

rholak commented 9 years ago

I use OMF for its plugins but do not use the theme functionality. When running the "omf list" command, the plugins display correctly but after the "Theme:" heading, it displays an error.

Example session:

~ $ omf list

Plugins: 
z gi git-flow grc mc msg

Theme: 
Array index out of bounds
~/.oh-my-fish/plugins/omf/omf.log.fish (line 5):       echo -e (set_color $argv[1])$argv[2..-1](set_color normal)
                                                                                        ^
in function “omf.log”
    called on line 49 of file ~/.oh-my-fish/plugins/omf/omf.packages.fish
    with parameter list “normal”

in function “omf.packages”
    called on line 15 of file ~/.oh-my-fish/plugins/omf/omf.fish
    with parameter list “--list”

in function “omf”
    called on standard input
    with parameter list “list”
bpinto commented 9 years ago

I don't think the code expects this, would you submit a PR checking this?

rholak commented 9 years ago

Recreated and resubmitted a cleaner version of my PR