oh-my-fish / oh-my-fish

The Fish Shell Framework
MIT License
10.35k stars 808 forks source link

`omf update <plugin>` should checkout branch specified in `packages-main` #905

Open lythesia opened 2 years ago

lythesia commented 2 years ago
Oh My Fish version:   7
OS type:              Darwin
Fish version:         fish, version 3.4.1
Git version:          git version 2.32.1 (Apple Git-133)
Git core.autocrlf:    no
Checking for a sane environment...
Your shell is ready to swim.

and errors

~ » omf update colored-man-pages
Updating https://github.com/oh-my-fish/packages-main master... Done!
fatal: couldn't find remote ref refs/heads/master
Could not update colored-man-pages.

same as #872 , and suspect the master/main branch naming Also tried remove and install, and then omf update still produce this error

scorphus commented 2 years ago

Unfortunately, the theme author decided to change the default branch form master to main.

Could you please try uninstalling and reinstalling the plugin?

omf uninstall colored-man-pages
omf install colored-man-pages

Let me know if that works.

lythesia commented 2 years ago

Also tried remove and install, and then omf update still produce this error

no :(

tennox commented 2 years ago

Same here, and /etc/fish/omf/pkg/fish-functions -> git remote show origin shows the correct branch:

HEAD branch: main

EDIT well... I see this issue covers a bit of a different but related issue - I created a separate PR instead: https://github.com/oh-my-fish/oh-my-fish/pull/908

scorphus commented 2 years ago

Also tried remove and install, and then omf update still produce this error

no :(

Note: once re-installed there's not need for an update.

inflation commented 2 years ago

Same issue with PatrickF1/fzf.fish. omf always fetch for master when updating.

brainz80 commented 8 months ago

Having same issue with PatrickF1/fzf.fish and meaningful-ooo/sponge.

Installed them by running omf install https://github.com/PatrickF1/fzf.fish and omf install https://github.com/meaningful-ooo/sponge