search

oh-my-fish / theme-agnoster

MIT License
95 stars 64 forks source link

Set the variable VIRTUAL_ENV_DISABLE_PROMPT to True. #11

Closed rubenvarela closed 8 years ago

rubenvarela commented 8 years ago

When activating a Python virtualenv, the activate code checks if this variable is set. If it empty, it will modify the prompt. Agnoster has this built in, so we set the variable to True to disable.

10 has the initial issue.

rubenvarela commented 8 years ago

The first time a virtualenv is used, the variable is set after the user activates the virtualenv. This means that the prompt will still be showed the first time.

The next time the users uses it though, the variable will be set and will be used.

There's no clean way of doing it at the this unless it's set globally from the start.

bobthecow commented 8 years ago

Some theme or another used to do this, and I believe the conclusion was reached that the theme should instruct the user to do this, and the theme should not set this automatically.

rubenvarela commented 8 years ago

@bobthecow I found this issue https://github.com/oh-my-fish/theme-bobthefish/issues/5. Based on the commit linked at the end, https://github.com/oh-my-fish/theme-bobthefish/commit/da9bf50279f8e8cbe239d63d29f942603d934906, I modified the README.md here.

I hope this is a better approach.

bobthecow commented 8 years ago

:+1: