search

oh-my-fish / theme-agnoster

MIT License
96 stars 64 forks source link

Generalize virtual environment to support Nix shell #44

Closed bakhtiyarneyman closed 4 years ago

sn0cr commented 4 years ago

The only thing I'm currently thinking about is, if we should put each environment into its own segment. Then it would be easier to distinguish which type of environment is currently active. Any thoughts about that? You might also want to add this feature to the Readme if you want 😉

bakhtiyarneyman commented 4 years ago

That's what I started with, but ultimately changed direction because I wan't sure how to proceed with respect to colors. I thought that it's probably not scalable to continue adding segments in this fashion. I also thought that it's unlikely that a person uses both python and nix environments in their day-to-day life, so it's better to group them.

I'm happy to implement what you propose if you tell me what color I should choose.

sn0cr commented 4 years ago

Oh yeah that's a good point, right now I'm not using NixOS but heard multiple times of it. Do you mind to add a description about the new feature to the readme? I will then merge it soon.

bakhtiyarneyman commented 4 years ago

Will do so tonight.

bakhtiyarneyman commented 4 years ago

Done. Thank you for the review!

sn0cr commented 4 years ago

Thank you for your contribution and making this theme better.