search

oh-my-fish / theme-agnoster

MIT License
94 stars 63 forks source link

Add mode prompt to hybrid key bindings. #60

Closed ken4306 closed 2 years ago

sn0cr commented 2 years ago

Hi @ken4306, could you provide more context what this PR solves? I'm not sure what your change does.

ken4306 commented 2 years ago

Hi @sn0cr,

This PR adds a mode indicator used in fish_vi_key_bindings, to fish_hybrid_key_bindings. Screenshot from 2022-05-13 17-49-11

sn0cr commented 2 years ago

Thanks!

ken4306 commented 2 years ago

I think mode indicator is for someone use vi keybindings and hybrid keybindings, because they need to know current mode. So if key bindings is not default key bindings, show the indicator. If it is default key bindings, do nothing.

sn0cr commented 2 years ago

I think mode indicator is for someone use vi keybindings and hybrid keybindings, because they need to know current mode. So if key bindings is not default key bindings, show the indicator. If it is default key bindings, do nothing.

Aah, thank you. You inverted the logic here, got it :+1: