Closed derekstavis closed 8 years ago
Seems good to me, but didn't test it. :D
@WBTMagnum, @sn0cr, could you guys test it there?
Request that we also add show_hg_prompt, show_git_prompt, etc. type configs to turn off segments when not desired. I have hg installed, but don't want to use it as it's very slow.
If that belongs in a separate PR let me know and I'll put one together.
The "use only when available" portion of this PR is working for me.
if we add them, please use the same names as bobthefish, for consistency between themes :)
@bobthecow it seems like we need to create helper functions for themes.
When we solve dependencies we can implement a theme plugin :D
@bpinto yeah, that would be nice. But for now, it would be enough to just use consistent environment vars to toggle things :)
@derekstavis tested the PR quickly. works fine here.
@nwykes :+1: on the configuration flags. should probably be a separate PR. regarding the naming, see the bobthefish config flags bobthecow mentioned.
Can we merge this? It's pretty urgent :shipit:
I misread the comments and thought there would be more commits coming, but they are going into another PR. =/
This PR fixes missing checks on VCS prompts which was causing issues when Mercurial isn't available: