search

oh-my-fish / theme-bobthefish

A Powerline-style, Git-aware fish theme optimized for awesome.
MIT License
1.46k stars 225 forks source link

Display screen session if you set theme_display_screen to yes #264

Closed pfsmorigo closed 7 months ago

pfsmorigo commented 4 years ago

I use multiple screen sessions so I would like to see which one I am in the current terminal.

pfsmorigo commented 4 years ago

Awesome. I like the idea, I like making it opt-in rather than opt-out.

Is there an analog the other settings which allow a verbose version, where it'd be useful to know you're in a screen session, but not necessarily which one? I imagine for someone who typically only ran one screen session per machine, that would be preferable.

Now it's opt-in without verbose. I don't know what to show if verbose is off. Currently only adds a space with the color. Maybe we can give me an idea.

About the screen name, the format is pid.tty.host: 

> screen -list
There are screens on:
        3226255.first  (09/03/2020 08:40:23 AM)        (Attached)
        2824062.second (09/03/2020 05:48:22 AM)        (Attached)
        1901576.third  (08/30/2020 09:18:26 AM)        (Attached)
3 Sockets in /run/screen/S-pfsmorigo.
> echo $STY
3226255.second

So I just use the second part (tty) as the screen session.

pfsmorigo commented 4 years ago

I don't know if I need to do something else. I think I did all requested changes.

pfsmorigo commented 3 years ago

@bobthecow Hello. I think I did all the requested modifications. What do I need to do in order to have this merged? Thanks!

pfsmorigo commented 3 years ago

@bobthecow Hello again! Is my pull request ok or should I change something?

pfsmorigo commented 1 year ago

Hello, is there something missing from my side? Can we merge this?

pfsmorigo commented 7 months ago

@bobthecow hello, can you merge this PR? Please let me know if you want me to change anything.

bobthecow commented 7 months ago

@pfsmorigo hi! I'm so sorry, for some reason I missed the pings entirely. I'll take a look!

bobthecow commented 7 months ago

I don't think I have a great thing to do when not verbose, so I'll merge this then remove that option ¯\_(ツ)_/¯

pfsmorigo commented 6 months ago

Thank!