Fix nord colorscheme for exit, su, jobs segments

oh-my-fish / theme-bobthefish

A Powerline-style, Git-aware fish theme optimized for awesome.

MIT License

1.44k stars 223 forks source link

Fix nord colorscheme for exit, su, jobs segments #274

Closed FMeinicke closed 3 years ago

FMeinicke commented 3 years ago

This PR fixes the IMO broken colors of the exit, su, and jobs segments in the nord color scheme as described in #234.
I've been using these colors for a while now and find them much more suitable than the original ones.

darrenkidd commented 3 years ago

Hey @FMeinicke, it might be nice to do a before and after comparison with bobthefish_display_colors nord to highlight the differences. Just to make it super easy on @bobthecow.

Also... as I'm no expert in colour schemes... what would your suggestion be for the nord colour scheme I've used in my new AWS segment in #266? I just made them up but I'm very open to suggestions to tweak them to something better (in a later PR).

EDIT: actually, see these lines for what I plan to be using in the future.

FYI: I also created a "Color Scheme Palettes" page in the Wiki which was useful to me when creating that segment. Any notes and updates on the nord scheme would be good to throw in there too methinks.

bobthecow commented 3 years ago

@darrenkidd thanks for the wiki page 🙂

FMeinicke commented 3 years ago

Hi @darrenkidd. I already did a before-after comparison in the issue I linked above (#234) but I'm happy to post this here again:

Before:

After:

Regarding your AWS segment: I actually really like the choice you made. I can't think of any better colors.

darrenkidd commented 3 years ago

Hi @darrenkidd. I already did a before-after comparison in the issue I linked above (#234)

Yep, had seen that, but just wanted to reduce the friction here for @bobthecow to get it merged.

Regarding your AWS segment: I actually really like the choice you made. I can't think of any better colors.

Cheers - thanks for the feedback! Much appreciated.

FMeinicke commented 3 years ago

Yep, had seen that, but just wanted to reduce the friction here for @bobthecow to get it merged.

Oh, alright. Good call, then! :smile:

bobthecow commented 3 years ago

What's going on with that Vagrant segment? 😬

FMeinicke commented 3 years ago

What's going on with that Vagrant segment? 😬

Well, ... don't know. I didn't change anything there. Do you want me to change the colors of this segment, as well?

bobthecow commented 3 years ago

Do you want me to change the colors of this segment, as well?

Nah, we can change that in another PR. Thanks!

FMeinicke commented 3 years ago

Alright. Thanks! 😄