search

oh-my-fish / theme-bobthefish

A Powerline-style, Git-aware fish theme optimized for awesome.
MIT License
1.44k stars 223 forks source link

Feature request: Add support for svn / Subversion #307

Open silverhook opened 2 years ago

silverhook commented 2 years ago

I know Subversion is very much out of fashion, but it still has its use (e.g. for contributing translations to KDE).

It would be ever so cool if this theme supported svn as it does git :)

bobthecow commented 2 years ago

I'd be open to a pull request if you want to implement it :)

silverhook commented 2 years ago

Fair :)

The problem being that I’m neither very savvy in Fish nor in SVN.

Let’s leave it open and if I (miraculously) manage to whip something up, I’ll open a pull request; but I hope someone else beats me to it.

silverhook commented 2 years ago

This might be a very stupid question, but is there any reason why this theme does not use fish_vcs_prompt?

https://fishshell.com/docs/current/cmds/fish_vcs_prompt.html

Otherwise, this might be a good source of inspiration, as it is a similar-looking theme that supports SVN: https://github.com/oh-my-fish/theme-agnoster/blob/43860ce1536930bca689470e26083b0a5b7bd6ae/functions/fish_prompt.fish

silverhook commented 2 years ago

There is also https://fishshell.com/docs/current/cmds/fish_svn_prompt.html

I just tried fish_svn_prompt as a stand-alone command and on my laptop it takes 4-7s, so not ideal for a prompt, perhaps.

silverhook commented 2 years ago

Perhaps it a MVP would be to just show an icon that the directory is an SVN repository.

That should at least make the user aware of the environment they are in and act accordingly.