show git tags if any - Githubissues

oh-my-fish / theme-bobthefish

A Powerline-style, Git-aware fish theme optimized for awesome.

MIT License

1.46k stars 225 forks source link

show git tags if any #311

Closed zztalker closed 7 months ago

zztalker commented 2 years ago

Without change tags not shown (because return happen earlier). With change tags shown if exists.

leo150 commented 1 year ago

bump

zztalker commented 1 year ago

@tommyknows @bobthecow Could you take a look?

bobthecow commented 1 year ago

Heh. Sorry about that, somehow I completely missed when this was opened 😬

bobthecow commented 1 year ago

Okay so it seems like this changes it to always show a tag and either a branch or commit ref. I'm not sure I love this, to be honest. In the cases where you're looking at a tag that's not the current branch head, showing the commit feels like it'll just add unnecessary noise.

zztalker commented 1 year ago

Okay so it seems like this changes it to always show a tag and either a branch or commit ref. I'm not sure I love this, to be honest. In the cases where you're looking at a tag that's not the current branch head, showing the commit feels like it'll just add unnecessary noise.

We can make it a configurable behavior. As for me, it adds not much noise, but useful.

bobthecow commented 1 year ago

no, that makes sense.

i'm specifically talking about the case where you check out a previous tag, which isn't a branch HEAD. previously, it would show the tag:

now it shows the tag and the commit:

the latter is just noise, IMO.