Add more options to conditionally show node version

oh-my-fish / theme-bobthefish

A Powerline-style, Git-aware fish theme optimized for awesome.

MIT License

1.46k stars 225 forks source link

Add more options to conditionally show node version #315

Closed hansl closed 2 years ago

hansl commented 2 years ago

There are now 4 options for $theme_display_node:

the default is (still) to never show it.
yes to always show the version.
rc to show it if we can find a .nvmrc or .node-version file in the parent directories.
package to show it if we can find a package.json file in the parent directories.

hansl commented 2 years ago

Hey @bobthecow , do you think there's anything missing from this PR? I've been using it locally for a while now and it works great. It just toggles whether or not the node version should be shown.

Basically I set it up so that I show only when there's a package.json, e.g.

Let me know, thanks!

hansl commented 2 years ago

@bobthecow Thanks for the review. I addressed all points. PTAL.

I have another similar PR with Rust support that I will update when this one is approved, and ping you on when ready.

Cheers!

hansl commented 2 years ago

This PR is ready to be merged if you have no other comment. Thank you very much for the thorough review.

bobthecow commented 2 years ago

Thank you!