oh-my-fish / theme-bobthefish

A Powerline-style, Git-aware fish theme optimized for awesome.
MIT License
1.44k stars 223 forks source link

Dracula theme: Fix Kubernetes colors #318

Closed AlyxPractice closed 2 years ago

AlyxPractice commented 2 years ago

Hello,

By default, the Kubernetes colors are displayed like so:

image

It's hard to read, and really bright, seeking for our attention. The purpose of displaying Kubernetes context is just to know where our kubectlcommands will run, so it's nice to know, but not a major information that should get all our attention in my opinion.

So I tried others colors, and either we could replace the white text with a darker color:

image

Or, what I suggest in this PR, use purple as it's less attention seeking:

image

Original version:

Screenshot 2021-12-28 at 14 16 44

Version with darker text:

Screenshot 2021-12-28 at 14 16 46

Suggested changes:

Screenshot 2021-12-28 at 14 16 49

Tell me what you think :)

bobthecow commented 2 years ago

You're right, that's terrible. Purple works for me. We actually use that for several other themes.

bobthecow commented 2 years ago

I've added k8s-context to bobthefish_display_colors to hopefully make this less likely to happen in the future?

e69150081b0e576ebb382487c1ff2cb35e78bb35

AlyxPractice commented 2 years ago

Awesome @bobthecow! Thanks a lot ❤️

bobthecow commented 2 years ago

Thank you!