oh-my-fish / theme-bobthefish

A Powerline-style, Git-aware fish theme optimized for awesome.
MIT License
1.46k stars 227 forks source link

Prompt for aws-vault uses wrong environment variable for expiration #350

Closed krissrex closed 8 months ago

krissrex commented 1 year ago

https://github.com/oh-my-fish/theme-bobthefish/blob/c2c47dc964a257131b3df2a127c2631b4760f3ec/functions/fish_prompt.fish#L663-L669

This is affected by a breaking change in aws-vault v7: https://github.com/99designs/aws-vault/releases/tag/v7.0.0 .

The correct environment variable for AWS_SESSION_EXPIRATION is now AWS_CREDENTIAL_EXPIRATION. It has a format like 2023-10-18T09:31:15Z.