oh-my-fish / theme-bobthefish

A Powerline-style, Git-aware fish theme optimized for awesome.
MIT License
1.44k stars 222 forks source link

Incompatibility introduced with commit e59687a25db82b312d22eeb831703a5abf2b0483 #365

Closed jean-bernard-valentaten closed 2 months ago

jean-bernard-valentaten commented 2 months ago

After upgrading to the recent version of this theme, I'm getting the following error:

Der Befehl 'path' wurde nicht gefunden, meinten Sie:
  Befehl 'mpath' aus dem deb libmodule-path-perl (0.19-1.1)
  Befehl 'path6' aus dem deb ipv6toolkit (2.0+ds.1-1)
  Befehl 'pat' aus dem deb dist (1:3.5-236-1)
  Befehl 'patch' aus dem deb patch (2.7.6-7build2)
  Befehl 'xpath' aus dem deb libxml-xpath-perl (1.44-1)
Versuche: sudo apt install <deb name>
~/.local/share/omf/themes/bobthefish/functions/fish_prompt.fish (line 1): 
path sort -r "$git_root_dir" "$hg_root_dir" "$fossil_root_dir"
^
in command substitution
    called on line 1317 of file ~/.local/share/omf/themes/bobthefish/functions/fish_prompt.fish
in function 'fish_prompt'
in command substitution
~/.local/share/omf/themes/bobthefish/functions/fish_prompt.fish (line 1317): Unknown command
    switch (path sort -r "$git_root_dir" "$hg_root_dir" "$fossil_root_dir")[1]
           ^
in function 'fish_prompt'
in command substitution

Im currently on Linux Mint 21.3 which uses fish version 3.3.1 and it seems that the command path was introduced in a more recent version. That said the issue was introduced by commit e59687a25db82b312d22eeb831703a5abf2b0483, which seems to break downward compatibility.

bobthecow commented 2 months ago

I believe this should be fixed with 0c15ff1cbc4bfa026c882e01dd5ceec327f26033

Do you mind confirming?

jean-bernard-valentaten commented 2 months ago

I can confirm that this fixes the issue. Thank you very much :)

bobthecow commented 2 months ago

Great, thank you!