search

oh-my-fish / theme-budspencer

A theme for nerds, makes fish even more powerful. It's equipped with a hell of a lot of nice functions and key bindings to speed up your workflow.
MIT License
106 stars 42 forks source link

Fish 3.0.2 has indent issues on MAC and WSL2 #60

Closed marcusm closed 5 years ago

marcusm commented 5 years ago

This only occurs for the budspencer theme. My other themes work fine.

2  ✔  cd ~
Fish has been upgraded, and the scripts on your system are not compatible with this prior instance of fish. You can probably run:

exec fish … to replace this process with a new one in-place.

in function 'alias' called on line 7 of file /usr/local/Cellar/fish/3.0.2/share/fish/functions/fish_indent.fish with parameter list 'fish_indent=/usr/local/Cellar/fish/3.0.2/bin/fish_indent'

from sourcing file /usr/local/Cellar/fish/3.0.2/share/fish/functions/fish_indent.fish called on line 263 of file ~/.config/fish/functions/fish_prompt.fish

in command substitution called on line 263 of file ~/.config/fish/functions/fish_prompt.fish

in command substitution called on line 527 of file ~/.config/fish/functions/fish_prompt.fish

in function '__budspencer_create_cmd_hist' called on standard input

in event handler: handler for generic event 'fish_prompt'

1  ✔  omf doctor  ~ Oh My Fish version: 6 OS type: Darwin Fish version: fish, version 3.0.2 Git version: git version 2.23.0 Git core.autocrlf: no Your shell is ready to swim.

clayauld commented 5 years ago

I've seen this error but only after an upgrade to fish or any components I had installed. In my case running exec fish fixed the issue. Is this the error you're seeing when you start a new terminal session? I am able to run this theme in Mac and WSL2 without issues at the moment.

phoenisx commented 5 years ago

I didn't want to open a new issue, since my issue resembles something what the title states here.

Screenshot 2019-11-08 at 2 47 21 PM

As you can see above, too much padding inbetween and to the extreme right. Also, single letter type (first keypress) causes the above issue, where the right prompt looks really awkward.

Screenshot 2019-11-08 at 2 58 31 PM
phoenisx commented 5 years ago

omf doctor

Oh My Fish version:   6
OS type:              Darwin
Fish version:         fish, version 3.0.2
Git version:          git version 2.24.0
Git core.autocrlf:    no
Your shell is ready to swim.

Terminal used is Alacritty, (issue doesn't occurs on MacOS Terminal app) but I don't think it's Alacritty issue.

clayauld commented 5 years ago

I don't see any issue like that in iTerm. Can you attempt to use iTerm to see how that behaves?

phoenisx commented 5 years ago

Yeah! It works in Terminal.app/iTerm.app as well. Would be Alacritty issue then. Thanks @clayauld

clayauld commented 5 years ago

Yes, the issue is likely with how Alacritty renders the theme. I'm not sure at all how that terminal emulator works, so I wouldn't be able to help you unless they found a fix and created a PR for it.