theme-dangerous is broken, gives lots of errors on every prompt

[JonathanReeve]

Here's the output after installing theme-dangerous:

[I] ⋊> ~/D/S/d/s/oh-my-fish on master ◦ omf install dangerous                                                                                          10:56:29
Updating https://github.com/oh-my-fish/packages-main master... Done!
Installing package dangerous
✔ dangerous successfully installed.
~/.config/fish/functions/fish_prompt.fish (line 6): Array index out of bounds
            set dangerous_current_bindmode_color $dangerous_colors[5]
                                                                   ^
in function “__dangerous_prompt_bindmode”
    called on line 752 of file ~/.config/fish/functions/fish_prompt.fish

in command substitution
    called on line 750 of file ~/.config/fish/functions/fish_prompt.fish

in function “fish_prompt”
    called on standard input

in command substitution
    called on standard input

~/.config/fish/functions/fish_prompt.fish (line 7): Array index out of bounds
            echo -en $dangerous_cursors[2]
                                        ^
in function “__dangerous_prompt_bindmode”
    called on line 752 of file ~/.config/fish/functions/fish_prompt.fish

in command substitution
    called on line 750 of file ~/.config/fish/functions/fish_prompt.fish

in function “fish_prompt”
    called on standard input

in command substitution
    called on standard input

~/.config/fish/functions/fish_prompt.fish (line 23): Array index out of bounds
        set_color $dangerous_colors[4]
                                    ^
in function “__dangerous_prompt_git_branch”
    called on line 752 of file ~/.config/fish/functions/fish_prompt.fish

in command substitution
    called on line 750 of file ~/.config/fish/functions/fish_prompt.fish

in function “fish_prompt”
    called on standard input

in command substitution
    called on standard input

~/.config/fish/functions/fish_prompt.fish (line 1): Array index out of bounds
set_color $dangerous_colors[3]
                            ^
in command substitution
    called on line 562 of file ~/.config/fish/functions/fish_prompt.fish

in function “__dangerous_prompt_left_symbols”
    called on line 752 of file ~/.config/fish/functions/fish_prompt.fish

in command substitution
    called on line 750 of file ~/.config/fish/functions/fish_prompt.fish

in function “fish_prompt”
    called on standard input

in command substitution
    called on standard input

~/.config/fish/functions/fish_prompt.fish (line 1): Array index out of bounds
set_color -o $dangerous_colors[12]
                               ^
in command substitution
    called on line 562 of file ~/.config/fish/functions/fish_prompt.fish

in function “__dangerous_prompt_left_symbols”
    called on line 752 of file ~/.config/fish/functions/fish_prompt.fish

in command substitution
    called on line 750 of file ~/.config/fish/functions/fish_prompt.fish

in function “fish_prompt”
    called on standard input

in command substitution
    called on standard input

~/.config/fish/functions/fish_prompt.fish (line 1): Array index out of bounds
set_color $dangerous_colors[3]
                            ^
in command substitution
    called on line 562 of file ~/.config/fish/functions/fish_prompt.fish

in function “__dangerous_prompt_left_symbols”
    called on line 752 of file ~/.config/fish/functions/fish_prompt.fish

in command substitution
    called on line 750 of file ~/.config/fish/functions/fish_prompt.fish

in function “fish_prompt”
    called on standard input

in command substitution
    called on standard input

Version info:

[I] ⋊> ~ fish --version; omf --version                                  11:01:10
fish, version 2.6.0
Oh My Fish version 5

[sagebind]

This is from a change in how Fish 2.5.0 handles out of bounds indexes. The plugin needs to be updated for sure.

[JonathanReeve]

Also unless I'm doing something wrong, $dangerous_colors doesn't appear to be set to anything.