search

oh-my-fish / theme-default

MIT License
40 stars 32 forks source link

Add `git stash` indicator #19

Closed alex-grover closed 2 years ago

alex-grover commented 3 years ago

This is a nice feature that the pure prompt has. It would be easy to adapt their implementation (here) into this prompt.

How it looks in pure, excuse the color scheme. Just installed it for this example screenshot

Screen Shot 2021-03-11 at 13 48 56

Not sure what the contribution process is for this repo, but happy to open a PR if this would be accepted!

alex-grover commented 3 years ago

@scorphus sorry to ping directly, looks like you're the only active member lately. please let me know if this change would be accepted, or else i can close the issue

scorphus commented 3 years ago

Hi, @ajgrover. No need to sorry, actually thanks for the ping.

I think this could be a nice feature to have. It would be nice if it was a completely opt-in feature, with accompanying documentation on how to activate. What do you think?

alex-grover commented 3 years ago

sounds good to me - will submit a PR when i have some time!

alex-grover commented 2 years ago

hi @scorphus, would appreciate a look at the PR if you have some time!

alex-grover commented 2 years ago

@scorphus one more ping - would love to get this merged

scorphus commented 2 years ago

Hey, sorry for not replying for so long.

I reckon that if changes are stashed and new changes are made, then the dirty indicator will have precedence, right? Can you please post screenshots of how each of these cases would look like?

Thanks!

alex-grover commented 2 years ago

added in the PR!